[
https://issues.apache.org/jira/browse/BEAM-10294?focusedWorklogId=463044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463044
]
ASF GitHub Bot logged work on BEAM-10294:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/20 17:06
Start Date: 24/Jul/20 17:06
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r460179800
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/SparkMetricsContainerStepMap.java
##########
@@ -27,7 +27,7 @@
@Override
public String toString() {
- return new SparkBeamMetric().renderAll().toString();
+ return asAttemptedOnlyMetricResults(this).toString();
Review comment:
> @ibzib Thanks for more details. I see the picture bit still not
convinced why MetricsContainerStepMap::toString is used for REST API (if I get
it right) - dedicated way to make the protobuf-formatted metrics accessible, as
you said, should be better imho.
The reason I used `toString` is because the Flink REST API displays
accumulator values using `toString`. I simply wasn't able to come up with a
dedicated way to make the protobuf-formatted metrics accessible.
> Are you ok to merge this fix for Spark Runner metrics?
Yes, this is fine for now. I might need to give Flink runner metrics another
look to make sure we don't have a similar problem there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463044)
Time Spent: 3h 40m (was: 3.5h)
> Beam metrics are unreadable in Spark history server
> ---------------------------------------------------
>
> Key: BEAM-10294
> URL: https://issues.apache.org/jira/browse/BEAM-10294
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Affects Versions: 2.13.0
> Reporter: David Janicek
> Assignee: David Janicek
> Priority: P2
> Attachments: image-2020-06-22-13-48-08-880.png
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Beam metrics shown in Spark history server are not readable. They're rendered
> as JSON which is created from protobuffer defined in *beam_job_api.proto*
> where metric's value is defined as bytes.
> !image-2020-06-22-13-48-08-880.png!
> Similar issue was already addressed and fixed in BEAM-6062 but was broken by
> BEAM-4552.
> Solution could be using *SparkMetricsContainerStepMap* instead of
> *MetricsContainerStepMap* inside *MetricsContainerStepMapAccumulator* as in
> BEAM-6062.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
