[
https://issues.apache.org/jira/browse/BEAM-6928?focusedWorklogId=463087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463087
]
ASF GitHub Bot logged work on BEAM-6928:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/20 18:26
Start Date: 24/Jul/20 18:26
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #12203:
URL: https://github.com/apache/beam/pull/12203#discussion_r460218999
##########
File path: sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py
##########
@@ -236,7 +236,10 @@ def enter_composite_transform(self, transform_node):
self.visit_transform(transform_node)
def visit_transform(self, transform_node):
- if [o for o in self.outputs if o in transform_node.inputs]:
+ # Internal consumers of the outputs we're overriding are expected.
Review comment:
This is because BQ FIle loads returns a series of pcollections (e.g.
files written, jobs started) - and if the downstream transforms depend on these
outputs, they will not work properly when replacing WriteToBQ with BQSink, so
we error out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463087)
Time Spent: 1h 20m (was: 1h 10m)
> Make Python SDK custom Sink the default Sink for BigQuery
> ---------------------------------------------------------
>
> Key: BEAM-6928
> URL: https://issues.apache.org/jira/browse/BEAM-6928
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This is for 2.14.0 - please bump version to 2.14.0 when doing 2.13.0 release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
