[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184394
]
ASF GitHub Bot logged work on BEAM-6184:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/19 23:04
Start Date: 11/Jan/19 23:04
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247245595
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamTableUtils.java
##########
@@ -90,6 +90,7 @@ public static String beamRow2CsvLine(Row row, CSVFormat
csvFormat) {
return writer.toString();
}
+ @SuppressWarnings("checkstyle:JavadocMethod")
Review comment:
Seems like it should have documentation. I suggest `Attempt to cast an
object to a specified Schema.Field.Type @throws IllegalArgumentException if the
value cannot be cast to that type`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 184394)
Time Spent: 2h 40m (was: 2.5h)
> PortableRunner dependency missed in wordcount example maven artifact
> --------------------------------------------------------------------
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
