[ 
https://issues.apache.org/jira/browse/BEAM-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Hulette updated BEAM-7996:
--------------------------------
    Description: 
In the initial [python RowCoder 
implementation|https://github.com/apache/beam/pull/9188] we only added support 
for the data types that already had coders in the Python SDK. We should add 
support for the remaining data types that are not currently supported:

* INT8 (ByteCoder in Java)
* INT16 (BigEndianShortCoder in Java)
* FLOAT (FloatCoder in Java)
* --BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)--
* --BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)--
* Map (MapCoder in Java)

We might consider making those coders standard so they can be tested 
independently from RowCoder in standard_coders.yaml. Or, if we don't do that we 
should probably add a more robust testing framework for RowCoder itself, 
because it will be challenging to test all of these types as part of the 
RowCoder tests in standard_coders.yaml.

  was:
In the initial [python RowCoder 
implementation|https://github.com/apache/beam/pull/9188] we only added support 
for the data types that already had coders in the Python SDK. We should add 
support for the remaining data types that are not currently supported:

* INT8 (ByteCoder in Java)
* INT16 (BigEndianShortCoder in Java)
* FLOAT (FloatCoder in Java)
* BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)
* BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)
* Map (MapCoder in Java)

We might consider making those coders standard so they can be tested 
independently from RowCoder in standard_coders.yaml. Or, if we don't do that we 
should probably add a more robust testing framework for RowCoder itself, 
because it will be challenging to test all of these types as part of the 
RowCoder tests in standard_coders.yaml.


> Add support for remaining data types in python RowCoder 
> --------------------------------------------------------
>
>                 Key: BEAM-7996
>                 URL: https://issues.apache.org/jira/browse/BEAM-7996
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Priority: P2
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the initial [python RowCoder 
> implementation|https://github.com/apache/beam/pull/9188] we only added 
> support for the data types that already had coders in the Python SDK. We 
> should add support for the remaining data types that are not currently 
> supported:
> * INT8 (ByteCoder in Java)
> * INT16 (BigEndianShortCoder in Java)
> * FLOAT (FloatCoder in Java)
> * --BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)--
> * --BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)--
> * Map (MapCoder in Java)
> We might consider making those coders standard so they can be tested 
> independently from RowCoder in standard_coders.yaml. Or, if we don't do that 
> we should probably add a more robust testing framework for RowCoder itself, 
> because it will be challenging to test all of these types as part of the 
> RowCoder tests in standard_coders.yaml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to