[
https://issues.apache.org/jira/browse/BEAM-10398?focusedWorklogId=464100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464100
]
ASF GitHub Bot logged work on BEAM-10398:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/20 08:01
Start Date: 29/Jul/20 08:01
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r461206822
##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -170,7 +170,7 @@ def get_last_run_id(
f"GCS location corresponding to artifacts built in this run: "
f"gs://beam-wheels-staging/{release_branch}/{release_commit}-{last_run_id}/"
)
- return safe_get(last_run, "id")
+ return last_run_id
Review comment:
My concerns are mostly around quota. If actions quota is not a concern,
then it's fine.
If it is easy to configure, i would skip "Upload to GCS" steps for merges to
master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 464100)
Time Spent: 11.5h (was: 11h 20m)
> Use GitHub Actions in release process (python)
> ----------------------------------------------
>
> Key: BEAM-10398
> URL: https://issues.apache.org/jira/browse/BEAM-10398
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Labels: python, release
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
