[
https://issues.apache.org/jira/browse/BEAM-9839?focusedWorklogId=463968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463968
]
ASF GitHub Bot logged work on BEAM-9839:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/20 07:49
Start Date: 29/Jul/20 07:49
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #12391:
URL: https://github.com/apache/beam/pull/12391#discussion_r461870594
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn<InputT, OutputT> doFn) {
}
@Override
- public K key() {
- return key;
+ public Object key() {
Review comment:
It seems a regression to not return the typed key. Can OnTimerContext
still be typed (necessitating perhaps a cast here)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463968)
Time Spent: 20m (was: 10m)
> OnTimerContext should not create a new one when processing each element/timer
> in FnApiDoFnRunner
> ------------------------------------------------------------------------------------------------
>
> Key: BEAM-9839
> URL: https://issues.apache.org/jira/browse/BEAM-9839
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Rehman Murad Ali
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:#24292e}The intent of these Context objects was to not create a new
> one when processing each element/timer and instead to reference a member
> variable as can be seen in:{color}
>
> Discussed here :
> https://github.com/apache/beam/pull/11154/#discussion_r416023080
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
