[
https://issues.apache.org/jira/browse/BEAM-10289?focusedWorklogId=465241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465241
]
ASF GitHub Bot logged work on BEAM-10289:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/20 01:47
Start Date: 01/Aug/20 01:47
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r463905457
##########
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##########
@@ -47,20 +47,21 @@ type DataSource struct {
splitIdx int64
start time.Time
- // rt is non-nil if this DataSource feeds directly to a splittable unit,
- // and receives the current restriction tracker being processed.
- rt chan sdf.RTracker
+ // su is non-nil if this DataSource feeds directly to a splittable unit,
+ // and receives that splittable unit when it is available for splitting.
+ su chan SplittableUnit
Review comment:
Improved this documentation for now, but this is part of concurrency
code I might be refactoring to avoid all the blocking, so it might just be gone
with the next commit I send.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 465241)
Time Spent: 2h (was: 1h 50m)
> Implement dynamic splitting support for SDFs in Go SDK.
> -------------------------------------------------------
>
> Key: BEAM-10289
> URL: https://issues.apache.org/jira/browse/BEAM-10289
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
