[
https://issues.apache.org/jira/browse/BEAM-6292?focusedWorklogId=184753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184753
]
ASF GitHub Bot logged work on BEAM-6292:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/19 11:02
Start Date: 14/Jan/19 11:02
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #7348: [BEAM-6292]
PasswordDecrypter: Delay decryption / Avoid serialization
URL: https://github.com/apache/beam/pull/7348#discussion_r247410598
##########
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##########
@@ -198,6 +201,16 @@ private CassandraIO() {}
return builder().setPassword(password).build();
}
+ /**
+ * Specify the password decrypter used to retrieve the raw password. It
delayed the decryption
+ * of the password when connecting to the cluster, which ensures that the
raw password is never
+ * serialized in the pipeline.
+ */
+ public Read<T> withPasswordDecrypter(PasswordDecrypter passwordDecrypter) {
Review comment:
There is a no knob philosophy of Beam: we should expose the least possible
amount of parameters to the user. This one is a technical/internal parameter
and moreover it is not a standard Cassandra parameter that the user could know.
Please provide a default decrypter and add a `withEncryptedPassword()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 184753)
Time Spent: 2h 10m (was: 2h)
> PasswordDecrypter: Delay decryption / Avoid serialization
> ---------------------------------------------------------
>
> Key: BEAM-6292
> URL: https://issues.apache.org/jira/browse/BEAM-6292
> Project: Beam
> Issue Type: Improvement
> Components: io-java-cassandra
> Reporter: Mathieu Blanchard
> Assignee: Mathieu Blanchard
> Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, the password is decrypted before the serialization of the pipeline
> and this causes the raw version to be visible to everyone on the staging
> location.
> To avoid this, we delayed the decryption of the password when connecting to
> the cluster, which ensures that the raw password is never serialized in the
> pipeline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
