[
https://issues.apache.org/jira/browse/BEAM-9500?focusedWorklogId=466125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466125
]
ASF GitHub Bot logged work on BEAM-9500:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 09:07
Start Date: 04/Aug/20 09:07
Worklog Time Spent: 10m
Work Description: piotr-szuberski edited a comment on pull request #11181:
URL: https://github.com/apache/beam/pull/11181#issuecomment-668478754
> @piotr-szuberski - what is the next step for this PR? Is it still active?
Should we close it?
Sorry for such delay, I totally forgot to response. I'll close this PR as
it's not that important and far outdated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466125)
Time Spent: 1.5h (was: 1h 20m)
> Refactor load tests
> -------------------
>
> Key: BEAM-9500
> URL: https://issues.apache.org/jira/browse/BEAM-9500
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michał Walenia
> Priority: P3
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> `make {{LoadTest}} parameterized instead of a base class.
> Each subclass of {{LoadTest}} is really just the main {{loadTest}} function
> and really that function is about the same as writing a {{PTransform}}. If
> you eliminate subclassing you can have {{LoadTest}} own the pipeline setup
> with so it will never be possible to forget or mess up
> {{readSourceFromOptions}} and {{ParDo.of(runtimeMonitor)}}. It will be less
> repeat boilerplate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
