[
https://issues.apache.org/jira/browse/BEAM-10240?focusedWorklogId=466441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466441
]
ASF GitHub Bot logged work on BEAM-10240:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 20:44
Start Date: 04/Aug/20 20:44
Worklog Time Spent: 10m
Work Description: ZijieSong946 commented on a change in pull request
#12348:
URL: https://github.com/apache/beam/pull/12348#discussion_r465319135
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlBeamTranslationUtils.java
##########
@@ -184,6 +188,19 @@ private static Value
beamLogicalObjectToZetaSqlValue(Object object, String ident
} else { // input type
return
Value.createTimeValue(CivilTimeEncoder.encodePacked64TimeNanos((LocalTime)
object));
}
+ } else if (SqlTypes.DATETIME.getIdentifier().equals(identifier)) {
+ // DateTime value
+ LocalDateTime datetime;
+ if (object instanceof Row) { // base type
+ datetime =
+ LocalDateTime.of(
+ LocalDate.ofEpochDay(((Row) object).getValue("Date")),
+ LocalTime.ofNanoOfDay(((Row) object).getValue("Time")));
+ } else { // input type
+ datetime = (LocalDateTime) object;
+ }
+ return Value.createDatetimeValue(
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466441)
Time Spent: 2h 10m (was: 2h)
> Support ZetaSQL DATETIME functions in BeamSQL
> ---------------------------------------------
>
> Key: BEAM-10240
> URL: https://issues.apache.org/jira/browse/BEAM-10240
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Support *all* DATETIME functions defined in ZetaSQL (BigQuery Standard SQL).
> See the list of functions below:
> [https://github.com/google/zetasql/blob/master/docs/datetime_functions.md|https://github.com/google/zetasql/blob/master/docs/time_functions.md]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
