[
https://issues.apache.org/jira/browse/BEAM-7996?focusedWorklogId=466490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466490
]
ASF GitHub Bot logged work on BEAM-7996:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 22:15
Start Date: 04/Aug/20 22:15
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #12426:
URL: https://github.com/apache/beam/pull/12426#issuecomment-668851393
Are we going to use this as a basis for a stand alone "beam:coder:map:v1"
urn type as well? As it stands I'll be changing Go to use this encoding for map
types by default anyway. Though I believe we don't have the equivalent
"beam:coder:optional/nullable" component wrapper urn to handle the other half
of this PR.
This comes up as the following: In the event users are serializing raw maps
or iterables with pointer components, the Go SDK will likely default to the
nullable interpretation. This comes into play with proto element types which
in Go are defaulted to pointers to structs. (However, this is probably a
non-issue if the proto type is decomposed into a schema instead.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466490)
Time Spent: 7h 20m (was: 7h 10m)
> Add support for remaining data types in python RowCoder
> --------------------------------------------------------
>
> Key: BEAM-7996
> URL: https://issues.apache.org/jira/browse/BEAM-7996
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> In the initial [python RowCoder
> implementation|https://github.com/apache/beam/pull/9188] we only added
> support for the data types that already had coders in the Python SDK. We
> should add support for the remaining data types that are not currently
> supported:
> * INT8 (ByteCoder in Java)
> * INT16 (BigEndianShortCoder in Java)
> * FLOAT (FloatCoder in Java) (Note: doubles are supported, this is
> specifically for single-precision)
> * --BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)--
> * --BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)--
> * Map (MapCoder in Java)
> We might consider making those coders standard so they can be tested
> independently from RowCoder in standard_coders.yaml. Or, if we don't do that
> we should probably add a more robust testing framework for RowCoder itself,
> because it will be challenging to test all of these types as part of the
> RowCoder tests in standard_coders.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
