[
https://issues.apache.org/jira/browse/BEAM-601?focusedWorklogId=467516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467516
]
ASF GitHub Bot logged work on BEAM-601:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 19:13
Start Date: 06/Aug/20 19:13
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#12422:
URL: https://github.com/apache/beam/pull/12422#discussion_r466629615
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/BasicKinesisProvider.java
##########
@@ -39,16 +40,27 @@
private final String secretKey;
private final Regions region;
private final @Nullable String serviceEndpoint;
+ private final boolean verifyCertificate;
BasicKinesisProvider(
- String accessKey, String secretKey, Regions region, @Nullable String
serviceEndpoint) {
+ String accessKey,
+ String secretKey,
+ Regions region,
+ @Nullable String serviceEndpoint,
+ boolean verifyCertificate) {
checkArgument(accessKey != null, "accessKey can not be null");
checkArgument(secretKey != null, "secretKey can not be null");
checkArgument(region != null, "region can not be null");
this.accessKey = accessKey;
this.secretKey = secretKey;
this.region = region;
this.serviceEndpoint = serviceEndpoint;
+ this.verifyCertificate = verifyCertificate;
+ }
+
+ BasicKinesisProvider(
Review comment:
When you use KinesisIO.write()..withAWSClientsProvider("accesskey",
"secretkey", "region", "serviceEndpointUrl") then without my modification beam
will try to use real AWS url instead of the given "serviceEndpointUrl". I don't
think this is the desired behaviour, but correct me if I'm wrong or I don't
understand something (which is very probable, I haven't used AWS much in my
life).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467516)
Time Spent: 8.5h (was: 8h 20m)
> Enable Kinesis integration tests
> --------------------------------
>
> Key: BEAM-601
> URL: https://issues.apache.org/jira/browse/BEAM-601
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Affects Versions: 0.3.0-incubating
> Reporter: Przemyslaw Pastuszka
> Assignee: Piotr Szuberski
> Priority: P3
> Labels: starter
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> There's an integration test for KinesisIO called KinesisReaderIT, but it is
> currently ignored, because it needs real Kinesis instance setup.
> As part of this task please:
> * setup real Kinesis environment on AWS for testing purposes
> * enable KinesisReaderIT test
> * setup jenkins, so that it passes all KinesisTestOptions when running
> integration tests
> This is a follow up to BEAM-461 requested by [[email protected]] in
> https://github.com/apache/incubator-beam/pull/687/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
