[
https://issues.apache.org/jira/browse/BEAM-10619?focusedWorklogId=467568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467568
]
ASF GitHub Bot logged work on BEAM-10619:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 21:02
Start Date: 06/Aug/20 21:02
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12440:
URL: https://github.com/apache/beam/pull/12440#discussion_r466684332
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -290,34 +298,60 @@ def to_callable(cond):
super(BeamDataframeDoctestRunner, self).__init__(
checker=_DeferrredDataframeOutputChecker(self._test_env, use_beam),
**kwargs)
+ self.skipped = 0
+ self.wont_implement = 0
def run(self, test, **kwargs):
self._checker.reset()
- if test.name in self._skip:
- for example in test.examples:
- if any(should_skip(example) for should_skip in self._skip[test.name]):
- example.source = 'pass'
- example.want = ''
for example in test.examples:
- if example.exc_msg is None:
+ if any(should_skip(example)
+ for should_skip in self._skip.get(test.name, [])):
+ example.source = 'pass'
+ example.want = ''
+ self.skipped += 1
+ elif example.exc_msg is None and any(
+ wont_implement(example)
+ for wont_implement in self._wont_implement.get(test.name, [])):
# Don't fail doctests that raise this error.
example.exc_msg = (
'apache_beam.dataframe.frame_base.WontImplementError: ...')
+ self.wont_implement += 1
Review comment:
Yeah that would be really good. Is it possible to get at that
information though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467568)
Time Spent: 50m (was: 40m)
> Report ratio of implemented pandas tests
> -----------------------------------------
>
> Key: BEAM-10619
> URL: https://issues.apache.org/jira/browse/BEAM-10619
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Measure and report (#implemented + #wont implement) / total # tests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
