[
https://issues.apache.org/jira/browse/BEAM-3608?focusedWorklogId=184942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184942
]
ASF GitHub Bot logged work on BEAM-3608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/19 20:26
Start Date: 14/Jan/19 20:26
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #7494: [BEAM-3608] Port
shaded Guava to vendored Guava
URL: https://github.com/apache/beam/pull/7494#issuecomment-454149304
1. We could use checkstyle as mentioned on list. I think maybe
`@SuppressWarnings` could work for exceptions. But actually if we enforce it in
the Gradle dependency level then you can't even import non-vendored Guava
anyhow. Great idea. I filed https://issues.apache.org/jira/browse/BEAM-6426 but
left it unassigned since I am not jumping on the task this minute.
2. I would like to make the shadow plugin inactive for almost all modules.
Totally agree. And once we move vendoring further, to stop using it entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 184942)
Time Spent: 9h 40m (was: 9.5h)
> Vendor Guava
> ------------
>
> Key: BEAM-3608
> URL: https://issues.apache.org/jira/browse/BEAM-3608
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Instead of shading as part of our build, we can shade before build so that it
> is apparent when reading code, and in IDEs, that a particular class resides
> in a hidden namespace.
> {{import com.google.common.reflect.TypeToken}}
> becomes something like
> {{import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken}}
> So we can very trivially ban `org.apache.beam.private` from public APIs
> unless they are annotated {{@Internal}}, and it makes sharing between our own
> modules never get broken by shading again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
