[
https://issues.apache.org/jira/browse/BEAM-10656?focusedWorklogId=468108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468108
]
ASF GitHub Bot logged work on BEAM-10656:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/20 23:18
Start Date: 07/Aug/20 23:18
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467324202
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java
##########
@@ -81,6 +89,22 @@ public DirectTimerInternals timerInternals() {
return timerInternals;
}
+ @Override
+ public BundleFinalizer bundleFinalizer() {
+ if (bundleFinalizer == null) {
+ bundleFinalizer = new InMemoryBundleFinalizer();
Review comment:
yup since most transforms won't use the bundle finalizer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468108)
Time Spent: 3h (was: 2h 50m)
> Java Direct runner supports Bundle Finalization
> -----------------------------------------------
>
> Key: BEAM-10656
> URL: https://issues.apache.org/jira/browse/BEAM-10656
> Project: Beam
> Issue Type: New Feature
> Components: runner-direct
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P1
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add support for the direct runner to invoke bundle finalization callbacks
> within DoFns.
> More details about the semantics within:
> https://s.apache.org/beam-finalizing-bundles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
