[
https://issues.apache.org/jira/browse/BEAM-9980?focusedWorklogId=468148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468148
]
ASF GitHub Bot logged work on BEAM-9980:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/20 02:12
Start Date: 08/Aug/20 02:12
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r467346745
##########
File path: build.gradle
##########
@@ -220,13 +220,12 @@ task pythonPreCommit() {
dependsOn ":sdks:python:test-suites:tox:py36:preCommitPy36"
dependsOn ":sdks:python:test-suites:tox:py37:preCommitPy37"
dependsOn ":sdks:python:test-suites:tox:py38:preCommitPy38"
- dependsOn ":sdks:python:test-suites:dataflow:py2:preCommitIT"
- dependsOn ":sdks:python:test-suites:dataflow:py2:preCommitIT_V2"
- dependsOn ":sdks:python:test-suites:dataflow:py37:preCommitIT"
- dependsOn ":sdks:python:test-suites:dataflow:py37:preCommitIT_V2"
- // We don't include Py35, Py36 precommit ITs to reduce quota footprint.
- // We can reconsider if we ever see an issue that these suites would
- // have caught. Note that the same tests will still run in postcommit.
+ dependsOn ":sdks:python:test-suites:dataflow:preCommitIT"
+ dependsOn ":sdks:python:test-suites:dataflow:preCommitIT_V2"
+ // We don't include all supported Python versions precommit ITs to
Review comment:
We can remove this comment.
##########
File path: build.gradle
##########
@@ -248,9 +247,9 @@ task pythonFormatterPreCommit() {
task python2PostCommit() {
dependsOn
":sdks:python:test-suites:portable:py2:crossLanguagePythonJavaKafkaIOFlink"
- dependsOn ":sdks:python:test-suites:portable:py2:crossLanguageTests"
+ dependsOn ":sdks:python:test-suites:portable:crossLanguageTests"
Review comment:
I'm not sure I follow this change - this is currently still a python2
PostCommit suite, so it should include py2 only tests.
However you could convert the targets that are not version-specific, such as
```
task portablePythonPreCommit()
task pythonSparkPostCommit()
```
to point to portable/build.gradle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468148)
Time Spent: 3h (was: 2h 50m)
> Specific Python version tied tests are to be version-selective
> --------------------------------------------------------------
>
> Key: BEAM-9980
> URL: https://issues.apache.org/jira/browse/BEAM-9980
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: yoshiki obata
> Assignee: yoshiki obata
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> We have some tests that we run only under specific Python versions,
> - FlinkValidatesRunner test runs using Python 3.5
> - HDFS Python 3 tests are running only with Python 3.7
> - Cross-language Py3 tests for Spark are running under Python 3.5
> etc...
> Python versions to run them under need to be switchable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
