[
https://issues.apache.org/jira/browse/BEAM-10549?focusedWorklogId=468794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468794
]
ASF GitHub Bot logged work on BEAM-10549:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/20 18:21
Start Date: 10/Aug/20 18:21
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #12352:
URL: https://github.com/apache/beam/pull/12352#issuecomment-671512461
> > As discussed in person, let's push the construction of a `{source_str:
TypeConstraint}` all the way up to the visitor.
>
> Just pushed these changes - PTAL
>
> I kept `get_perf_runtime_type_hints` because it's merely responsible for
unpickling the function to get the constructed type hints dict
The problem with this function is that it's called on all sorts of
operations, even those without type constraints, when it applies to only one
kind of operation. This pattern (and the heavy use of hasattr) suggests it'd be
better to make this a method on Operation, say with default of return None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468794)
Time Spent: 3h 50m (was: 3h 40m)
> Improve Runtime Type Checking Performance
> -----------------------------------------
>
> Key: BEAM-10549
> URL: https://issues.apache.org/jira/browse/BEAM-10549
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Assignee: Saavan Nanavati
> Priority: P2
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The performance gain will come from moving the runtime type check from a
> decorator to OperationCounters.
>
> This has (2) improvements:
> # Cython optimizable
> # Sampling is a built-in feature
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
