[
https://issues.apache.org/jira/browse/BEAM-10292?focusedWorklogId=469190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469190
]
ASF GitHub Bot logged work on BEAM-10292:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 12:23
Start Date: 11/Aug/20 12:23
Worklog Time Spent: 10m
Work Description: davidak09 commented on a change in pull request #12050:
URL: https://github.com/apache/beam/pull/12050#discussion_r468538993
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/DefaultFilenamePolicy.java
##########
@@ -182,19 +184,26 @@ public void encode(Params value, OutputStream outStream)
throws IOException {
if (value == null) {
throw new CoderException("cannot encode a null value");
}
- stringCoder.encode(value.baseFilename.get().toString(), outStream);
- stringCoder.encode(value.shardTemplate, outStream);
- stringCoder.encode(value.suffix, outStream);
+ STRING_CODER.encode(value.baseFilename.get().toString(), outStream);
+ STRING_CODER.encode(value.shardTemplate, outStream);
+ STRING_CODER.encode(value.suffix, outStream);
+ BOOLEAN_CODER.encode(value.baseFilename.get().isDirectory(), outStream);
}
@Override
public Params decode(InputStream inStream) throws IOException {
- ResourceId prefix =
-
FileBasedSink.convertToFileResourceIfPossible(stringCoder.decode(inStream));
- String shardTemplate = stringCoder.decode(inStream);
- String suffix = stringCoder.decode(inStream);
+ String prefix = STRING_CODER.decode(inStream);
+ String shardTemplate = STRING_CODER.decode(inStream);
+ String suffix = STRING_CODER.decode(inStream);
+ ResourceId baseFilename;
+ if (inStream.available() > 0) {
+ baseFilename = FileSystems.matchNewResource(prefix,
BOOLEAN_CODER.decode(inStream));
+ } else {
+ // fallback for ensure backward compatibility
+ baseFilename = FileBasedSink.convertToFileResourceIfPossible(prefix);
Review comment:
Hi @lukecwik, finally after the discussion in the mailing list I chose
the second proposed option and fixed the underlying filesystem. Turns out that
only `LocalFileSystem` is broken, on the other hand e.g. HDFS and S3 look fine
and already have this kind of check.
I still think that the proper solution should be to use the
`ResourceIdCoder` instead of `StringUtf8Coder` but I understand the
consequences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469190)
Time Spent: 2h 10m (was: 2h)
> DefaultFilenamePolicy.ParamsCoder loses information whether Params's resource
> ID is file/directory
> --------------------------------------------------------------------------------------------------
>
> Key: BEAM-10292
> URL: https://issues.apache.org/jira/browse/BEAM-10292
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: David Janicek
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> *DefaultFilenamePolicy.ParamsCoder* uses simple *StringUtf8Coder* for
> encoding/decoding *DefaultFilenamePolicy.Params*'s *baseFilename* and
> therefore looses information whether *Params.baseFilename* resource ID is
> file or directory.
> The result is that it's effectively preventing user to define directory as
> *baseFilename provider* when using dynamic destinations because after
> deserialization it's translated to file.
> Solution is easy - use *ResourceIdCoder* for encoding/decoding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
