[
https://issues.apache.org/jira/browse/BEAM-8125?focusedWorklogId=469375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469375
]
ASF GitHub Bot logged work on BEAM-8125:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 19:44
Start Date: 11/Aug/20 19:44
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12521:
URL: https://github.com/apache/beam/pull/12521#discussion_r468822570
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/SchemaCoderTest.java
##########
@@ -290,5 +329,31 @@ public void coderConsistentWithEquals() throws Exception {
}
}
}
+
+ @Test
+ public void verifyDeterministic() throws Exception {
+ if (expectDeterministic) {
+ assertDeterministic(coder);
+ } else {
+ assertNonDeterministic(coder);
+ }
+ }
+ }
+
+ private static void assertDeterministic(SchemaCoder coder) {
Review comment:
Thanks! Added a commit to use verifyDeterministic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469375)
Time Spent: 40m (was: 0.5h)
> SchemaCoder/RowCoder.verifyDeterministic throws NPE when schema has a logical
> type
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8125
> URL: https://issues.apache.org/jira/browse/BEAM-8125
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.15.0
> Reporter: Brian Hulette
> Priority: P2
> Labels: stale-P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
