[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=469838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469838
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/20 17:45
Start Date: 12/Aug/20 17:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12519:
URL: https://github.com/apache/beam/pull/12519#discussion_r469433033
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvoker.java
##########
@@ -211,10 +211,6 @@ public FinishBundleContext
finishBundleContext(DoFn<InputT, OutputT> doFn) {
KV<RestrictionT, KV<Instant, WatermarkEstimatorStateT>> residual =
processContext.getTakenCheckpoint();
if (cont.shouldResume()) {
- checkState(
Review comment:
I added this check back and altered how we were passing forward the
self-checkpoing signal from the UnboundedSource through the SDF wrapper instead.
The check is valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469838)
Time Spent: 2h (was: 1h 50m)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
