[
https://issues.apache.org/jira/browse/BEAM-10695?focusedWorklogId=470449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470449
]
ASF GitHub Bot logged work on BEAM-10695:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/20 21:46
Start Date: 13/Aug/20 21:46
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #12558:
URL: https://github.com/apache/beam/pull/12558#discussion_r470267221
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -501,9 +501,11 @@ def evict_computed_pcollections(self, pipeline=None):
is specified, evicts for all pipelines.
"""
if pipeline:
+ discarded = set()
for pcoll in self._computed_pcolls:
if pcoll.pipeline is pipeline:
- self._computed_pcolls.discard(pcoll)
+ discarded.add(pcoll)
+ self._computed_pcolls -= discarded
Review comment:
Don't you need to call discard on `_computed_pcolls`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470449)
Time Spent: 0.5h (was: 20m)
> Cannot evict PCollections from InteractiveEnvironment
> -----------------------------------------------------
>
> Key: BEAM-10695
> URL: https://issues.apache.org/jira/browse/BEAM-10695
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The code in the InteractiveEnvironment manipulates the _computed_pcollections
> set while iterating.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
