[ 
https://issues.apache.org/jira/browse/BEAM-10587?focusedWorklogId=470769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470769
 ]

ASF GitHub Bot logged work on BEAM-10587:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/20 17:15
            Start Date: 14/Aug/20 17:15
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r470752028



##########
File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -679,6 +714,20 @@ private static Object convertAvroArray(
     return ret;
   }
 
+  private static Object convertAvroMap(
+      FieldType beamField, Object value, BigQueryUtils.ConversionOptions 
options) {
+    List<GenericData.Record> records = (List<GenericData.Record>) value;
+    HashMap<Object, Object> ret = new HashMap<>();

Review comment:
       We prefer to use ImmutableMap when possible, there are examples in this 
file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 470769)
    Time Spent: 2h 10m  (was: 2h)

> Support Maps in BigQuery
> ------------------------
>
>                 Key: BEAM-10587
>                 URL: https://issues.apache.org/jira/browse/BEAM-10587
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Ryan Worley
>            Assignee: Ryan Worley
>            Priority: P2
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Maps are currently not supported when converting a Beam Schema to a BigQuery 
> TableFieldSchema.  This improvement will convert Maps to repeated records 
> with 'key' and 'value' fields.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to