[
https://issues.apache.org/jira/browse/BEAM-7587?focusedWorklogId=471304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471304
]
ASF GitHub Bot logged work on BEAM-7587:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/20 22:58
Start Date: 16/Aug/20 22:58
Worklog Time Spent: 10m
Work Description: annaqin418 commented on a change in pull request #12157:
URL: https://github.com/apache/beam/pull/12157#discussion_r471169567
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPortableStreamingPipelineOptions.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.spark;
+
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.options.Default;
+import org.apache.beam.sdk.options.Description;
+import org.apache.beam.sdk.options.PipelineOptions;
+import org.apache.beam.sdk.options.PortablePipelineOptions;
+
+/**
+ * Spark runner {@link PipelineOptions} handles Spark execution-related
configurations, such as the
+ * master address, batch-interval, and other user-related knobs.
+ */
+@Experimental
+public interface SparkPortableStreamingPipelineOptions
+ extends SparkPipelineOptions, PortablePipelineOptions, PipelineOptions {
+ @Description("Timeout for testing Spark portable streaming, in
milliseconds.")
+ @Default.Long(-1L)
Review comment:
This is a good question, I couldn't find documentation on the proper way
to have no timeout. Typically it seems that you would just use two entirely
separate methods, awaitTermination() and awaitTerminationOrTimeout(). -1L
simply appeared to give the desired behavior...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471304)
Time Spent: 2h 40m (was: 2.5h)
> Spark portable runner: Streaming mode
> -------------------------------------
>
> Key: BEAM-7587
> URL: https://issues.apache.org/jira/browse/BEAM-7587
> Project: Beam
> Issue Type: Wish
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Anna Qin
> Priority: P2
> Labels: portability-spark
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> So far all work on the Spark portable runner has been in batch mode. This is
> intended as an uber-issue for tracking progress on adding support for
> streaming.
> -It might be advantageous to wait for the structured streaming (non-portable)
> runner to be completed (to some reasonable extent) before undertaking this,
> rather than using the DStream API.- Since work on the structured streaming
> runner is blocked by SPARK-26655, we should implement this using DStreams
> instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
