[
https://issues.apache.org/jira/browse/BEAM-10549?focusedWorklogId=471309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471309
]
ASF GitHub Bot logged work on BEAM-10549:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/20 23:43
Start Date: 16/Aug/20 23:43
Worklog Time Spent: 10m
Work Description: saavannanavati commented on a change in pull request
#12352:
URL: https://github.com/apache/beam/pull/12352#discussion_r471174427
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1465,6 +1465,11 @@ def get_restriction_coder(self):
from apache_beam.runners.common import DoFnSignature
return DoFnSignature(self.fn).get_restriction_coder()
+ def _add_type_constraint_from_consumer(self, full_label, input_type_hints):
Review comment:
Yes, we store this information during `get_input_type_hints` which
produces the data that's passed to `_add_type_constraint_from_consumer`.
I added a test called
`test_downstream_input_type_hint_error_has_descriptive_error_msg` to confirm
this behavior, but let me know if that doesn't cover the case you're talking
about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471309)
Time Spent: 7.5h (was: 7h 20m)
> Improve Runtime Type Checking Performance
> -----------------------------------------
>
> Key: BEAM-10549
> URL: https://issues.apache.org/jira/browse/BEAM-10549
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Assignee: Saavan Nanavati
> Priority: P2
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> The performance gain will come from moving the runtime type check from a
> decorator to OperationCounters.
>
> This has (2) improvements:
> # Cython optimizable
> # Sampling is a built-in feature
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
