[
https://issues.apache.org/jira/browse/BEAM-9891?focusedWorklogId=471705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471705
]
ASF GitHub Bot logged work on BEAM-9891:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/20 22:26
Start Date: 17/Aug/20 22:26
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #12601:
URL: https://github.com/apache/beam/pull/12601#discussion_r471808675
##########
File path:
sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRun.java
##########
@@ -19,22 +19,38 @@
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.PipelineResult.State;
import java.util.concurrent.Callable;
/**
* To fulfill multi-threaded execution
*/
-public class TpcdsRun implements Callable<PipelineResult> {
+public class TpcdsRun implements Callable<TpcdsRunResult> {
private final Pipeline pipeline;
public TpcdsRun (Pipeline pipeline) {
this.pipeline = pipeline;
}
@Override
- public PipelineResult call() {
- PipelineResult pipelineResult = pipeline.run();
- pipelineResult.waitUntilFinish();
- return pipelineResult;
+ public TpcdsRunResult call() {
+ TpcdsRunResult tpcdsRunResult;
+
+ try {
+ PipelineResult pipelineResult = pipeline.run();
+ long startTimeStamp = System.currentTimeMillis();
+ State state = pipelineResult.waitUntilFinish();
+ long endTimeStamp = System.currentTimeMillis();
+
+ // Make sure to set the job status to be successful only when
pipelineResult's final state is DONE.
+ boolean isSuccessful = state == State.DONE;
Review comment:
Nit: add parentheses around `state == State.DONE;`, which increases
readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471705)
Time Spent: 5h 20m (was: 5h 10m)
> TPC benchmarks for BeamSQL
> --------------------------
>
> Key: BEAM-9891
> URL: https://issues.apache.org/jira/browse/BEAM-9891
> Project: Beam
> Issue Type: Task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Yuwei Fu
> Priority: P2
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> TPC benchmarks [1] are industrial standard that we can adopt for BeamSQL.
> There are references from Spark[2] and Flink[3] that are using it. This Jira
> tracks the effort to integrate TPC benchmarks with BeamSQL.
> [1]: http://www.tpc.org/information/benchmarks.asp
> [2]: https://github.com/databricks/spark-sql-perf
> [3]:
> https://github.com/apache/flink/tree/master/flink-end-to-end-tests/flink-tpcds-test
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
