[
https://issues.apache.org/jira/browse/BEAM-9919?focusedWorklogId=471735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471735
]
ASF GitHub Bot logged work on BEAM-9919:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/20 23:57
Start Date: 17/Aug/20 23:57
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471837313
##########
File path: sdks/go/pkg/beam/core/graph/xlang.go
##########
@@ -0,0 +1,129 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package graph
+
+import (
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
+ pipepb "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
+)
+
+type ExpandedTransform struct {
+ Components_ interface{} // *pipepb.Components
+ Transform_ interface{} //*pipepb.PTransform
+ Requirements_ []string
+ BoundedOutputs_ map[string]bool
+}
+
+func (exp *ExpandedTransform) Components() *pipepb.Components {
+ if c, ok := exp.Components_.(*pipepb.Components); ok {
+ return c
+ }
+ panic(errors.Errorf("malformed components; %v lacks a conforming
pipeline component", exp))
+}
+
+func (exp *ExpandedTransform) Transform() *pipepb.PTransform {
+ if t, ok := exp.Transform_.(*pipepb.PTransform); ok {
+ return t
+ }
+ panic(errors.Errorf("malformed transform; %v lacks a conforming
pipeline ptransform", exp))
+}
+
+func (exp *ExpandedTransform) Requirements() []string {
+ if exp.Requirements_ != nil {
+ return exp.Requirements_
+ }
+ return nil
+}
+
+func (exp *ExpandedTransform) BoundedOutputs() map[string]bool {
+ if exp.BoundedOutputs_ != nil {
+ return exp.BoundedOutputs_
+ }
+ return nil
+}
+
+// ExternalTransform represents the cross-language transform in and out of the
Pipeline as a MultiEdge and Expanded proto respectively
+type ExternalTransform struct {
+ Urn string
+ Payload []byte
+ ExpansionAddr string
+
+ //replace all input/output fields with Inbound and Outbound id maps
referencing the orginal Multiedge
+
+ inputs map[string]*Node
+ Outputs map[string]*Node
+ outputTypes map[string]typex.FullType
+
+ Expanded_ *ExpandedTransform
+}
+
+func (ext ExternalTransform) WithNamedInputs(inputs map[string]*Node)
ExternalTransform {
+ if ext.inputs != nil {
+ panic(errors.Errorf("inputs already set as: \n%v", ext.inputs))
+ }
+ ext.inputs = inputs
+ return ext
+}
+
+func (ext ExternalTransform) WithNamedOutputs(outputTypes
map[string]typex.FullType) ExternalTransform {
Review comment:
Good use of a value method here and the similar functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471735)
Time Spent: 6h 20m (was: 6h 10m)
> Add an External transform API to Go SDK
> ---------------------------------------
>
> Key: BEAM-9919
> URL: https://issues.apache.org/jira/browse/BEAM-9919
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Kevin Sijo Puthusseri
> Priority: P2
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> This transform will be able to expand cross-language transforms by connecting
> to a remote expansion service through Beam expansion API.
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_expansion_api.proto]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
