[
https://issues.apache.org/jira/browse/BEAM-10597?focusedWorklogId=471767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471767
]
ASF GitHub Bot logged work on BEAM-10597:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/20 02:04
Start Date: 18/Aug/20 02:04
Worklog Time Spent: 10m
Work Description: robinyqiu commented on a change in pull request #12403:
URL: https://github.com/apache/beam/pull/12403#discussion_r471830220
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchModeExecutionContext.java
##########
@@ -543,6 +547,16 @@ public Long extractThrottleTime() {
totalThrottleTime += httpClientApiThrottlingTime.getCumulative();
}
+ CounterCell bigqueryStreamingInsertThrottleTime =
+ container.tryGetCounter(
+ MetricName.named(
+ BIGQUERY_STREAMING_INSERT_THROTTLE_TIME_NAMESPACE,
+ BIGQUERY_STREAMING_INSERT_THROTTLE_TIME_NAME));
Review comment:
Hi @chamikaramj @ihji ! I have made the change such that BQ, GCS, and
Datastore all report throttled time in milliseconds at the beginning, and they
now share the common counter name for consistency. The millisecond to second
conversion is done only when later a throttled time in seconds is expected by
worker side code. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471767)
Time Spent: 1h 50m (was: 1h 40m)
> Propagate BigQuery streaming insert throttled time to Dataflow worker
> ---------------------------------------------------------------------
>
> Key: BEAM-10597
> URL: https://issues.apache.org/jira/browse/BEAM-10597
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Robin Qiu
> Assignee: Robin Qiu
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
