[
https://issues.apache.org/jira/browse/BEAM-10752?focusedWorklogId=472488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-472488
]
ASF GitHub Bot logged work on BEAM-10752:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/20 15:54
Start Date: 19/Aug/20 15:54
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12625:
URL: https://github.com/apache/beam/pull/12625#discussion_r473133184
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
##########
@@ -101,8 +97,14 @@ public void testSimpleInsert() throws Exception {
BeamSqlRelUtils.toPCollection(pipeline,
sqlEnv.parseQuery(insertStatement));
+ Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(1));
Review comment:
In other places this was used it seemed like 5 mins was the default.
```suggestion
Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(5));
```
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
##########
@@ -158,8 +154,14 @@ public void testSimpleInsertFlat() throws Exception {
BeamSqlRelUtils.toPCollection(pipeline,
sqlEnv.parseQuery(insertStatement));
+ Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(1));
Review comment:
```suggestion
Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(5));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 472488)
Time Spent: 1h 50m (was: 1h 40m)
> [beam_PostCommit_SQL] PubsubToBigqueryIT.testSimpleInsert failed
> ----------------------------------------------------------------
>
> Key: BEAM-10752
> URL: https://issues.apache.org/jira/browse/BEAM-10752
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql, test-failures
> Reporter: Robin Qiu
> Assignee: Brian Hulette
> Priority: P1
> Labels: currently-failing
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> java.lang.AssertionError: Expected: iterable with items [<Row:[3, foo]>,
> <Row:[5, bar]>, <Row:[7, baz]>] in any order but: no item matches: <Row:[3,
> foo]>, <Row:[5, bar]>, <Row:[7, baz]> in []
> [https://ci-beam.apache.org/job/beam_PostCommit_SQL/5208/testReport/junit/org.apache.beam.sdk.extensions.sql/PubsubToBigqueryIT/testSimpleInsert/]
>
> This happened after https://issues.apache.org/jira/browse/BEAM-10716
> Maybe the pubsub subscription is accidentally deleted? Brian could you please
> take a look?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
