[
https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=472500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-472500
]
ASF GitHub Bot logged work on BEAM-3301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/20 16:15
Start Date: 19/Aug/20 16:15
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #12628:
URL: https://github.com/apache/beam/pull/12628#discussion_r473145499
##########
File path: sdks/go/pkg/beam/core/graph/fn.go
##########
@@ -167,6 +167,23 @@ const (
// TODO: ViewFn, etc.
)
+var methodNames = []string{
Review comment:
Consider using a map[string]struct{} instead instead of looping over a
slice.
Alternatively, given that this is a combination of both doFnNames and
sdfNames, consider
var methodNames = append(append(nil, doFnNames...), sdfNames...)
which avoids duplicating the constant lists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 472500)
Time Spent: 12h 50m (was: 12h 40m)
> Go SplittableDoFn support
> -------------------------
>
> Key: BEAM-3301
> URL: https://issues.apache.org/jira/browse/BEAM-3301
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> SDFs will be the only way to add streaming and liquid sharded IO for Go.
> Design doc: https://s.apache.org/splittable-do-fn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
