[
https://issues.apache.org/jira/browse/BEAM-5987?focusedWorklogId=185866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185866
]
ASF GitHub Bot logged work on BEAM-5987:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 16:45
Start Date: 16/Jan/19 16:45
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7091: [BEAM-5987]
Spark: Share cached side inputs between tasks.
URL: https://github.com/apache/beam/pull/7091#discussion_r248355041
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/util/CachedSideInputReader.java
##########
@@ -86,9 +55,27 @@ private CachedSideInputReader(SideInputReader delegate) {
@Override
public <T> T get(PCollectionView<T> view, BoundedWindow window) {
Review comment:
I am worried on the possible semantics consequences of
`CachedSideInputReader.get()` returning a `null` value when it is not in the
`Cache` for this. Wouldn't it imply that a window could get an empty side input
assigned?
[The
documentation](https://github.com/apache/beam/blob/6c2fe17cfdea1be1fdcfb02267894f0d37a671b3/runners/core-java/src/main/java/org/apache/beam/runners/core/SideInputReader.java#L32)
on this is not really clear (pinging @kennknowles to see if I am misreading
it).
Wonder if there is a test to validate that this cannot happen or if we can
create one somehow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 185866)
Time Spent: 6h (was: 5h 50m)
> Spark SideInputReader performance
> ---------------------------------
>
> Key: BEAM-5987
> URL: https://issues.apache.org/jira/browse/BEAM-5987
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Affects Versions: 2.8.0
> Reporter: David Moravek
> Assignee: David Moravek
> Priority: Major
> Fix For: 2.9.0
>
> Attachments: Screen Shot 2018-11-06 at 13.05.36.png
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> We did some profiling of a spark job and 90% of the application time was
> spent on side input deserialization.
> For spark, an easy fix is to cache materialized side inputs per bundle. This
> improved running time of the profiled job from 3 hours to 30 minutes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
