Ning Kang created BEAM-10764:
--------------------------------

             Summary: Make is_in_ipython robust
                 Key: BEAM-10764
                 URL: https://issues.apache.org/jira/browse/BEAM-10764
             Project: Beam
          Issue Type: Improvement
          Components: runner-py-interactive
            Reporter: Ning Kang
            Assignee: Ning Kang


`is_in_ipython` determines if current code execution is within an IPython 
environment by attempting to fetch an IPython kernel through 
`IPython.get_ipython()`.

If IPython dependency is not available or a `None` is fetched, the result would 
be False.

We've been seeing some users using corrupted IPython dependency in their code 
base.
If an IPython dependency is present but throws a non ImportError exception, it 
will break the Beam usage.
I assume the similar errors would happen if the user uses an IPython dependency 
outside the range of versions in setup.py.

I decide to make the function best effort so that it always returns False when 
errors occur.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to