[
https://issues.apache.org/jira/browse/BEAM-10699?focusedWorklogId=473110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473110
]
ASF GitHub Bot logged work on BEAM-10699:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/20 22:47
Start Date: 20/Aug/20 22:47
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #12609:
URL: https://github.com/apache/beam/pull/12609#discussion_r474312991
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -131,7 +133,12 @@ public JobService getJobService(BigQueryOptions options) {
@Override
public DatasetService getDatasetService(BigQueryOptions options) {
- return new DatasetServiceImpl(options);
+ return new DatasetServiceImpl(options, null);
+ }
+
+ @Override
+ public DatasetService getDatasetService(BigQueryOptions options, Histogram
histogram) {
Review comment:
We create a new service instance per bundle, so it would be hard to
aggregate the result across multiple bundles if we don't pass a histogram
instance from outside of the service constructor.
We could also instantiate a histogram object inside the service constructor
and merge them later but it's more time consuming (need an iteration over the
bucket array).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473110)
Time Spent: 3h (was: 2h 50m)
> Identify and log additional information needed to debug streaming insert
> requests
> ---------------------------------------------------------------------------------
>
> Key: BEAM-10699
> URL: https://issues.apache.org/jira/browse/BEAM-10699
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp, io-py-gcp
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> implement logging for per worker statistics:
> - Request count - for that window.
> - Error codes + number of occurrences for that window (Or perhaps just log
> each error with as much detail as possible.)
> - Tail latencies of requests (50, 90 and 99, percentiles)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
