[
https://issues.apache.org/jira/browse/BEAM-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robin Qiu updated BEAM-10783:
-----------------------------
Description:
Some WITH queries, like:
??WITH t1 AS (select 1 AS k), t2 AS (select 1 AS k), t3 AS (select 1 AS k)??
?? SELECT COUNT(*)??
?? FROM t1 JOIN t3 USING (k)??
failed on ZetaSQL because how column index is calculated in
JoinScanWithRefConverter is not correct.
In fact, the other converter responsible for JOINs, JoinScanConverter, has the
correct implementation, and that works fine for JOINs that has reference to
WITH queries. So I believe we should delete the incorrect
JoinScanWithRefConverter class and move to the other one.
was:
Some WITH queries, like:
```
WITH t1 AS (select 1 AS k), t2 AS (select 1 AS k), t3 AS (select 1 AS k)
SELECT COUNT\(*\)
FROM t1 JOIN t3 USING (k)
```
failed on ZetaSQL because how column index is calculated in
JoinScanWithRefConverter is not correct.
In fact, the other converter responsible for JOINs, JoinScanConverter, has the
correct implementation, and that works fine for JOINs that has reference to
WITH queries. So I believe we should delete the incorrect
JoinScanWithRefConverter class and move to the other one.
> ZetaSQL failed on WITH queries because wrong ref column index calculated in
> JoinScanWithRefConverter
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-10783
> URL: https://issues.apache.org/jira/browse/BEAM-10783
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Robin Qiu
> Priority: P2
>
> Some WITH queries, like:
> ??WITH t1 AS (select 1 AS k), t2 AS (select 1 AS k), t3 AS (select 1 AS k)??
> ?? SELECT COUNT(*)??
> ?? FROM t1 JOIN t3 USING (k)??
> failed on ZetaSQL because how column index is calculated in
> JoinScanWithRefConverter is not correct.
>
> In fact, the other converter responsible for JOINs, JoinScanConverter, has
> the correct implementation, and that works fine for JOINs that has reference
> to WITH queries. So I believe we should delete the incorrect
> JoinScanWithRefConverter class and move to the other one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
