[
https://issues.apache.org/jira/browse/BEAM-10697?focusedWorklogId=473186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473186
]
ASF GitHub Bot logged work on BEAM-10697:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 03:43
Start Date: 21/Aug/20 03:43
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #12652:
URL: https://github.com/apache/beam/pull/12652#discussion_r474391456
##########
File path: CHANGES.md
##########
@@ -83,7 +83,8 @@
## Known Issues
-* Fixed X (Java/Python)
([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
+* (Python) Performance impact due to occasional erroneous conversions from
bytes/str to
Review comment:
Looks like this is getting a fix soon after all (#12654), so we might
just be able to cherry pick the fix in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473186)
Time Spent: 1.5h (was: 1h 20m)
> Python Precommit failing due to type check failure.
> ---------------------------------------------------
>
> Key: BEAM-10697
> URL: https://issues.apache.org/jira/browse/BEAM-10697
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, test-failures
> Reporter: Daniel Oliveira
> Assignee: Udi Meiri
> Priority: P0
> Fix For: 2.24.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Test suite: https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/
> First failure: https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/3110/
> Looks like it's failing for about a day now.
> Error:
> {noformat}
> self = <apache_beam.transforms.ptransform_test.PTransformTypeCheckTestCase
> testMethod=test_pardo_properly_type_checks_using_type_hint_decorators>
> def test_pardo_properly_type_checks_using_type_hint_decorators(self):
> @with_input_types(a=str)
> @with_output_types(typing.List[str])
> def to_all_upper_case(a):
> return [a.upper()]
>
> # If this type-checks than no error should be raised.
> d = (
> self.p
> | 'T' >> beam.Create(['t', 'e', 's', 't']).with_output_types(str)
> | 'Case' >> beam.FlatMap(to_all_upper_case))
> assert_that(d, equal_to(['T', 'E', 'S', 'T']))
> self.p.run()
>
> # Output type should have been recognized as 'str' rather than
> List[str] to
> # do the flatten part of FlatMap.
> > self.assertEqual(str, d.element_type)
> E AssertionError: <type 'str'> != Any
> apache_beam/transforms/ptransform_test.py:1182: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
