[
https://issues.apache.org/jira/browse/BEAM-10137?focusedWorklogId=473239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473239
]
ASF GitHub Bot logged work on BEAM-10137:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 07:40
Start Date: 21/Aug/20 07:40
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#12297:
URL: https://github.com/apache/beam/pull/12297#discussion_r474416306
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -295,14 +300,16 @@
private static final int DEFAULT_NUM_RETRIES = 6;
/** Returns a new {@link Read} transform for reading from Kinesis. */
- public static Read read() {
- return new AutoValue_KinesisIO_Read.Builder()
- .setMaxNumRecords(Long.MAX_VALUE)
- .setUpToDateThreshold(Duration.ZERO)
-
.setWatermarkPolicyFactory(WatermarkPolicyFactory.withArrivalTimePolicy())
- .setRateLimitPolicyFactory(RateLimitPolicyFactory.withoutLimiter())
- .setMaxCapacityPerShard(ShardReadersPool.DEFAULT_CAPACITY_PER_SHARD)
- .build();
+ public static Read<KinesisRecord> read() {
Review comment:
The worst thing I can imagine is that a user will get a raw type warning
if he used it like `KinesisIO.Read read = KinesisIO.read();`. Some users could
have some checkers that would turn it into an error though. I don't know how
much common such tools are in the Java development in projects using Beam.
`PCollection<KinesisRecord> = pipeline.apply(KinesisIO.read()...));` doesn't
change so I think it's ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473239)
Time Spent: 11.5h (was: 11h 20m)
> Add cross-language wrapper for Java's KinesisIO Read
> ----------------------------------------------------
>
> Key: BEAM-10137
> URL: https://issues.apache.org/jira/browse/BEAM-10137
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, io-java-kinesis, io-py-aws
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's KinesisIO Read
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
