[
https://issues.apache.org/jira/browse/BEAM-10764?focusedWorklogId=473387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473387
]
ASF GitHub Bot logged work on BEAM-10764:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 18:07
Start Date: 21/Aug/20 18:07
Worklog Time Spent: 10m
Work Description: robertwb merged pull request #12641:
URL: https://github.com/apache/beam/pull/12641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473387)
Time Spent: 1.5h (was: 1h 20m)
> Make is_in_ipython robust
> -------------------------
>
> Key: BEAM-10764
> URL: https://issues.apache.org/jira/browse/BEAM-10764
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> `is_in_ipython` determines if current code execution is within an IPython
> environment by attempting to fetch an IPython kernel through
> `IPython.get_ipython()`.
> If IPython dependency is not available or a `None` is fetched, the result
> would be False.
> We've been seeing some users using corrupted IPython dependency in their code
> base.
> If an IPython dependency is present but throws a non ImportError exception,
> it will break the Beam usage.
> I assume the similar errors would happen if the user uses an IPython
> dependency outside the range of versions in setup.py.
> I decide to make the function best effort so that it always returns False
> when errors occur.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
