[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=473388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473388
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 18:15
Start Date: 21/Aug/20 18:15
Worklog Time Spent: 10m
Work Description: leiyiz commented on a change in pull request #12580:
URL: https://github.com/apache/beam/pull/12580#discussion_r474853441
##########
File path:
sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_launcher.py
##########
@@ -262,13 +285,13 @@ def run(self):
query_duration =
self.pipeline_options.view_as(TestOptions).wait_until_finish_duration #
pylint: disable=line-too-long
if launch_from_direct_runner:
command = Command(
- self.run_query, args=[queries[i], query_args.get(i), query_errors])
+ self.run_query, args=[queries[i], query_args, query_errors])
command.run(timeout=query_duration // 1000)
else:
try:
- self.run_query(queries[i], query_args.get(i), query_errors=None)
+ self.run_query(queries[i], query_args, query_errors=query_errors)
Review comment:
because a lot of queries actually want the same arg options and because
we are doing dict lookup inside the queries anyway due to more than 1 query
args, I just removed the per-query args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473388)
Time Spent: 19h 50m (was: 19h 40m)
> Implement a Python version of the Nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing, testing-nexmark
> Reporter: Ismaël Mejía
> Priority: P3
> Labels: newbie, nexmark, starter
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
