[
https://issues.apache.org/jira/browse/BEAM-10597?focusedWorklogId=473431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473431
]
ASF GitHub Bot logged work on BEAM-10597:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 20:14
Start Date: 21/Aug/20 20:14
Worklog Time Spent: 10m
Work Description: robinyqiu commented on a change in pull request #12663:
URL: https://github.com/apache/beam/pull/12663#discussion_r474929840
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1257,6 +1260,7 @@ def _flush_batch(self, destination):
_LOGGER.info(
'Sleeping %s seconds before retrying insertion.', retry_backoff)
time.sleep(retry_backoff)
+ self._throttled_secs.inc(retry_backoff)
Review comment:
I think we can consider that as an improvement. Currently the metric is
reported to autoscalar, so I simply made it a `counter`, similar to the ones in
[GCS](https://github.com/apache/beam/blob/3d0f7dc011bb7bbee4eea9525b82f53855de85f1/sdks/python/apache_beam/io/gcp/gcsio_overrides.py#L37)
and
[DataStore](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py#L316)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473431)
Time Spent: 4h 10m (was: 4h)
> Propagate BigQuery streaming insert throttled time to Dataflow worker
> ---------------------------------------------------------------------
>
> Key: BEAM-10597
> URL: https://issues.apache.org/jira/browse/BEAM-10597
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Robin Qiu
> Assignee: Robin Qiu
> Priority: P2
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
