[
https://issues.apache.org/jira/browse/BEAM-10783?focusedWorklogId=473456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473456
]
ASF GitHub Bot logged work on BEAM-10783:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 22:15
Start Date: 21/Aug/20 22:15
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #12648:
URL: https://github.com/apache/beam/pull/12648#issuecomment-678538579
LGTM
I agreed with Andrew's point. There might be something else that had
happened to make this changes possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473456)
Time Spent: 0.5h (was: 20m)
> ZetaSQL failed on WITH queries because wrong ref column index calculated in
> JoinScanWithRefConverter
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-10783
> URL: https://issues.apache.org/jira/browse/BEAM-10783
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Robin Qiu
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Some WITH queries, like:
> WITH t1 AS (select 1 AS k), t2 AS (select 1 AS k), t3 AS (select 1 AS k)
> SELECT COUNT\(*\)
> FROM t1 JOIN t3 USING (k)
> failed on ZetaSQL because how column index is calculated in
> JoinScanWithRefConverter is not correct.
>
> In fact, the other converter responsible for JOINs, JoinScanConverter, has
> the correct implementation, and that works fine for JOINs that has reference
> to WITH queries. So I believe we should delete the incorrect
> JoinScanWithRefConverter class and move to the other one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
