[
https://issues.apache.org/jira/browse/BEAM-10658?focusedWorklogId=474097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474097
]
ASF GitHub Bot logged work on BEAM-10658:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/20 23:58
Start Date: 24/Aug/20 23:58
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r475960972
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference
ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return
builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
Review comment:
Is this format standardized ? If so can we add a reference here ?
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference
ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return
builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
}
- @VisibleForTesting
- static TableReference toTableRef(TableReferenceProto.TableReference ref) {
- return new TableReference()
- .setProjectId(ref.getProjectId())
- .setDatasetId(ref.getDatasetId())
- .setTableId(ref.getTableId());
+ static String toTableResourceName(TableReference tableReference) {
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474097)
Remaining Estimate: 23h 20m (was: 23.5h)
Time Spent: 40m (was: 0.5h)
> Update BigQuery storage API from v1beta1 to v1
> ----------------------------------------------
>
> Key: BEAM-10658
> URL: https://issues.apache.org/jira/browse/BEAM-10658
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Affects Versions: 2.22.0
> Reporter: Kenneth Jung
> Assignee: Kenneth Jung
> Priority: P2
> Original Estimate: 24h
> Time Spent: 40m
> Remaining Estimate: 23h 20m
>
> The BigQuery storage sources need to be updated to use v1 of the BigQuery
> storage API in preparation for turning down v1beta1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
