[
https://issues.apache.org/jira/browse/BEAM-5910?focusedWorklogId=186412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186412
]
ASF GitHub Bot logged work on BEAM-5910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 16:42
Start Date: 17/Jan/19 16:42
Worklog Time Spent: 10m
Work Description: jklukas commented on issue #6914: [BEAM-5910] Add
lastModified field to MatchResult.Metadata
URL: https://github.com/apache/beam/pull/6914#issuecomment-455241780
Fixed the typos, converted both MetadataCoder and MetadataCoderV2 to
singletons, and added tests.
I responded to the comment on `UNKNOWN_LAST_MODIFIED_MILLIS`. The tests
exercise that the new code and validate that behavior is how I intended
(MetadataCoder discards lastModifiedMillis when encoding and provides a default
value on decoding). I believe that proves backwards compatibility, but do let
me know if there's some additional nuance I'm missing there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186412)
Time Spent: 3.5h (was: 3h 20m)
> FileSystems should retrieve lastModified time
> ---------------------------------------------
>
> Key: BEAM-5910
> URL: https://issues.apache.org/jira/browse/BEAM-5910
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Jeff Klukas
> Priority: Minor
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> In the Java SDK, the Filesystems.match facilities are aimed at listing file
> names and collect very limited additional metadata from the filesystem
> (sizeBytes and isReadSeekEfficient). I propose adding a new field for
> lastModified time to MatchResult.Metadata that each FileSystem would populate
> when listing files.
> This would be a basis for a future improvement to
> FileIO.match(...).continuously(...) where we could let the user opt to poll
> not just for new file names, but also for existing file names if their
> content has been updated.
> In the near term, the addition of lastModified to Metadata would allow users
> to implement their own polling logic on top of Filesystems.match to detect
> and download new files from any of the supported filesystems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
