[
https://issues.apache.org/jira/browse/BEAM-10303?focusedWorklogId=474915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474915
]
ASF GitHub Bot logged work on BEAM-10303:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/20 17:35
Start Date: 26/Aug/20 17:35
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r477472322
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/HandlesSplits.java
##########
@@ -35,6 +36,12 @@
/** Returns the current progress of the active element as a fraction between
0.0 and 1.0. */
double getProgress();
+ String getPtranformId();
Review comment:
I believe we should be using the transform ids from the local transform.
In the window observing truncate case where we have both element splits from
`process` and window splits from `truncate` then:
* the element splits should use the transform/input id from `process`
* the whole window splits should use the transform/input id from `truncate`
We may need changes on Dataflow runner v2 to make sure it supports this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474915)
Time Spent: 7h 50m (was: 7h 40m)
> FnApiDoFnRunner window observing optimization
> ---------------------------------------------
>
> Key: BEAM-10303
> URL: https://issues.apache.org/jira/browse/BEAM-10303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Labels: portability
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Currently the FnApiDoFnRunner processes each element within it's own window.
> There is an easy optimization where we process the element once if and only
> if the function doesn't observe the window (either directly or indirectly via
> side inputs/state/...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
