[
https://issues.apache.org/jira/browse/BEAM-6428?focusedWorklogId=186525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186525
]
ASF GitHub Bot logged work on BEAM-6428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 20:07
Start Date: 17/Jan/19 20:07
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #7545: [BEAM-6428]
Add a textual selection syntax for schema fields.
URL: https://github.com/apache/beam/pull/7545#discussion_r248816308
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldAccessDescriptor.java
##########
@@ -245,43 +452,39 @@ private static Schema getFieldSchema(Field field) {
return type.getMapValueType().getRowSchema();
} else {
throw new IllegalArgumentException(
- "Field " + field + " must be either a row or " + " a container
containing rows");
+ "FieldType " + type + " must be either a row or " + " a container
containing rows");
Review comment:
nit: You should drop the `" + "`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186525)
Time Spent: 0.5h (was: 20m)
> Allow textual selection syntax for schema fields
> ------------------------------------------------
>
> Key: BEAM-6428
> URL: https://issues.apache.org/jira/browse/BEAM-6428
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Affects Versions: 2.9.0
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
