[
https://issues.apache.org/jira/browse/BEAM-9891?focusedWorklogId=475004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475004
]
ASF GitHub Bot logged work on BEAM-9891:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/20 20:49
Start Date: 26/Aug/20 20:49
Worklog Time Spent: 10m
Work Description: Imfuyuwei commented on a change in pull request #12436:
URL: https://github.com/apache/beam/pull/12436#discussion_r477580621
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamTableUtils.java
##########
@@ -151,10 +151,16 @@ public static Object autoCastField(Schema.Field field,
Object rawObj) {
case INT32:
return Integer.valueOf(raw);
case INT64:
+ if (raw.equals("")) {
+ return null;
Review comment:
Yes, data in format of CSV files are read by this autoCastField method
and converted to various types.
When input data field is empty, it needs to be treated as NULL manually,
otherwise it will cause error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475004)
Time Spent: 6h (was: 5h 50m)
> TPC benchmarks for BeamSQL
> --------------------------
>
> Key: BEAM-9891
> URL: https://issues.apache.org/jira/browse/BEAM-9891
> Project: Beam
> Issue Type: Task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Yuwei Fu
> Priority: P2
> Time Spent: 6h
> Remaining Estimate: 0h
>
> TPC benchmarks [1] are industrial standard that we can adopt for BeamSQL.
> There are references from Spark[2] and Flink[3] that are using it. This Jira
> tracks the effort to integrate TPC benchmarks with BeamSQL.
> [1]: http://www.tpc.org/information/benchmarks.asp
> [2]: https://github.com/databricks/spark-sql-perf
> [3]:
> https://github.com/apache/flink/tree/master/flink-end-to-end-tests/flink-tpcds-test
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
