[
https://issues.apache.org/jira/browse/BEAM-6280?focusedWorklogId=186536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186536
]
ASF GitHub Bot logged work on BEAM-6280:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 20:18
Start Date: 17/Jan/19 20:18
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7433: [BEAM-6280]
Refactors Python portability tests to be multi-threaded aware
URL: https://github.com/apache/beam/pull/7433#discussion_r248825648
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -217,11 +217,22 @@ def send_prepare_request(max_retries=5):
staging_location='')
else:
retrieval_token = None
+
+ # Run the job and wait for a result.
run_response = job_service.Run(
beam_job_api_pb2.RunJobRequest(
preparation_id=prepare_response.preparation_id,
retrieval_token=retrieval_token))
- return PipelineResult(job_service, run_response.job_id, cleanup_callbacks)
+
+ state_stream = job_service.GetStateStream(
Review comment:
So, it seems we still have a bit of a race here (though it's as tight as can
be).
What if you tried getting the streams basted on the
prepare_response.preparation_id, and only if that fails you fall back to
getting them after starting the job? In the meantime, we can switch all runners
to not have two separate ids (is there a JIRA for this? If not, please file
one) and then remove the workaround.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186536)
Time Spent: 5.5h (was: 5h 20m)
> Failure in PortableRunnerTest.test_error_traceback_includes_user_code
> ---------------------------------------------------------------------
>
> Key: BEAM-6280
> URL: https://issues.apache.org/jira/browse/BEAM-6280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, test-failures
> Reporter: Kenneth Knowles
> Assignee: Sam Rohde
> Priority: Critical
> Labels: flaky-test
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> [https://builds.apache.org/job/beam_PreCommit_Python_Cron/732/]
> [https://builds.apache.org/job/beam_PreCommit_Python_Cron/732/testReport/apache_beam.runners.portability.portable_runner_test/PortableRunnerTest/test_error_traceback_includes_user_code/]
> [https://scans.gradle.com/s/do3hjulee3gaa/console-log?task=:beam-sdks-python:testPython3]
> {code:java}
> 'second' not found in 'Traceback (most recent call last):\n File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py",
> line 466, in test_error_traceback_includes_user_code\n p |
> beam.Create([0]) | beam.Map(first) # pylint:
> disable=expression-not-assigned\n File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/pipeline.py",
> line 425, in __exit__\n self.run().wait_until_finish()\n File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Cron/src/sdks/python/apache_beam/runners/portability/portable_runner.py",
> line 314, in wait_until_finish\n self._job_id, self._state,
> self._last_error_message()))\nRuntimeError: Pipeline
> job-cdcefe6d-1caa-4487-9e63-e971f67ec68c failed in state FAILED: start
> <DataInputOperation receivers=[ConsumerSet[Create/Read/Impulse.out0,
> coder=WindowedValueCoder[BytesCoder], len(consumers)=1]]>\n'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
