[
https://issues.apache.org/jira/browse/BEAM-10699?focusedWorklogId=475060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475060
]
ASF GitHub Bot logged work on BEAM-10699:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/20 23:54
Start Date: 26/Aug/20 23:54
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #12609:
URL: https://github.com/apache/beam/pull/12609#discussion_r477711001
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/Histogram.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.util;
+
+import java.math.RoundingMode;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.math.DoubleMath;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** A histogram that supports estimated percentile with linear interpolation.
*/
+public class Histogram {
Review comment:
I couldn't find any 3rd party library that satisfies our interface
requirements such as exponential or explicit bucket definitions. Also, the
current usecase is simple enough that we could avoid introducing additional
dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475060)
Time Spent: 4.5h (was: 4h 20m)
> Identify and log additional information needed to debug streaming insert
> requests for Java SDK
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-10699
> URL: https://issues.apache.org/jira/browse/BEAM-10699
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> implement logging for per worker statistics:
> - Request count - for that window.
> - Error codes + number of occurrences for that window (Or perhaps just log
> each error with as much detail as possible.)
> - Tail latencies of requests (50, 90 and 99, percentiles)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
