[
https://issues.apache.org/jira/browse/BEAM-6868?focusedWorklogId=475860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475860
]
ASF GitHub Bot logged work on BEAM-6868:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/20 15:30
Start Date: 28/Aug/20 15:30
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12706:
URL: https://github.com/apache/beam/pull/12706#discussion_r479379349
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -905,6 +928,19 @@ public final void notifyCheckpointComplete(long
checkpointId) throws Exception {
bufferingDoFnRunner.checkpointCompleted(checkpointId);
}
+ List<InMemoryBundleFinalizer.Finalization> finalizations =
+ pendingFinalizations.get(checkpointId);
+ if (finalizations != null) {
+ // remove old finalizations except for the current one
+ pendingFinalizations.clear();
+ pendingFinalizations.put(checkpointId, finalizations);
Review comment:
I was basing my logic off of UnboundedSourceWrapper which seemed flawed
but didn't know enough as to why it was done that way there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 475860)
Time Spent: 1h (was: 50m)
> Flink runner supports Bundle Finalization
> -----------------------------------------
>
> Key: BEAM-6868
> URL: https://issues.apache.org/jira/browse/BEAM-6868
> Project: Beam
> Issue Type: New Feature
> Components: cross-language, runner-flink
> Reporter: Boyuan Zhang
> Priority: P1
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
