[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186999&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186999
]
ASF GitHub Bot logged work on BEAM-6184:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/19 19:00
Start Date: 18/Jan/19 19:00
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7532:
[BEAM-6184]Make checkstyle report error on missing javadocmethod
URL: https://github.com/apache/beam/pull/7532#discussion_r249150468
##########
File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml
##########
@@ -30,4 +30,65 @@
<suppress checks=".*" files=".+[\\\/]generated-src[\\\/].+\.java" />
<suppress checks=".*" files=".+[\\\/]generated-sources[\\\/].+\.java" />
<suppress checks=".*" files=".+[\\\/]generated-test-sources[\\\/].+\.java" />
+
+ <!-- Suppression on JavadocMethod violations.
+
+ The goal is to remove all the following suppressions, once they are
addressed.
+
+ Tracking JIRA:BEAM-6446
+ -->
+
+ <!-- sdk -->
+ <suppress checks="JavadocMethod" files=".*sdk.*Experimental\.java"
lines="48,112"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*DefaultCoder\.java"
lines="54"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*FileIO\.java" lines="800"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*OffsetRangeTracker\.java"
lines="83"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*Default\.java" lines="40"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*Description\.java"
lines="34"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*TransformHierarchy\.java"
lines="144"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*Schema\.java" lines="363"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*DefaultSchema\.java"
lines="65"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*SchemaFieldName\.java"
lines="52"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*Cast\.java" lines="332,391"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*DoFn\.java" lines="444"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*CoGbkResult\.java"
lines="72"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*extensions.*Audience\.java"
lines="32"/>
+ <suppress checks="JavadocMethod"
files=".*sdk.*clickhouse.*ClickHouseIO\.java" lines="467"/>
+ <suppress checks="JavadocMethod"
files=".*sdk.*clickhouse.*ClickHouseWriter\.java" lines="47"/>
+ <suppress checks="JavadocMethod"
files=".*sdk.*sql.*BeamSetOperatorsTransforms\.java" lines="59"/>
+ <suppress checks="JavadocMethod"
files=".*sdk.*nexmark.*GeneratorConfig\.java" lines="89"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*CassandraServiceImpl\.java"
lines="112"/>
+ <suppress checks="JavadocMethod" files=".*sdk.*gcp.*AvroUtils\.java"
lines="28"/>
+ <suppress checks="JavadocMethod"
files=".*sdk.*testing.*BigqueryClient\.java" lines="277,357,454"/>
Review comment:
Is this multiple file suppressions collapsed to a single line? And is this
just for conciseness?
One downside is that it obfuscates a bit where the actual errors are.
Perhaps it would be better to have each line here at least have the full
filename so that individuals could quickly identify where they need to fix
something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186999)
Time Spent: 8h 10m (was: 8h)
> PortableRunner dependency missed in wordcount example maven artifact
> --------------------------------------------------------------------
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
