[
https://issues.apache.org/jira/browse/BEAM-10779?focusedWorklogId=476402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476402
]
ASF GitHub Bot logged work on BEAM-10779:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/20 07:39
Start Date: 31/Aug/20 07:39
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12655:
URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461
# [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report
> Merging
[#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc)
will **increase** coverage by `2.27%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12655 +/- ##
==========================================
+ Coverage 34.47% 36.74% +2.27%
==========================================
Files 684 1138 +454
Lines 81483 135219 +53736
Branches 9180 9182 +2
==========================================
+ Hits 28090 49692 +21602
- Misses 52965 85106 +32141
+ Partials 428 421 -7
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=)
| `24.27% <22.22%> (ø)` | |
|
[pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cGlwZWxpbmVfdGVzdC5weQ==)
| `24.44% <0.00%> (-0.35%)` | :arrow_down: |
|
[io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=)
| `34.95% <0.00%> (ø)` | |
|
[runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==)
| `32.88% <0.00%> (ø)` | |
|
[io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=)
| `34.49% <0.00%> (ø)` | |
|
[typehints/typed\_pipeline\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVkX3BpcGVsaW5lX3Rlc3QucHk=)
| `21.98% <0.00%> (ø)` | |
|
[runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `28.45% <0.00%> (ø)` | |
|
[runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==)
| `25.49% <0.00%> (ø)` | |
|
[runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==)
| `18.11% <0.00%> (ø)` | |
|
[...amples/snippets/transforms/elementwise/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9fX2luaXRfXy5weQ==)
| `100.00% <0.00%> (ø)` | |
| ... and [454
more](https://codecov.io/gh/apache/beam/pull/12655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=footer). Last
update
[cfa448d...34348a0](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 476402)
Time Spent: 1h 20m (was: 1h 10m)
> Support multiple main inputs and side inputs for PTransformOverride
> -------------------------------------------------------------------
>
> Key: BEAM-10779
> URL: https://issues.apache.org/jira/browse/BEAM-10779
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Yifan Mai
> Assignee: Yifan Mai
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently, {{PTransformOverride}} only supports overriding {{PTransform}} s
> that have a [single
> input|https://github.com/apache/beam/blob/cfa448d121297398312d09c531258a72b413488b/sdks/python/apache_beam/pipeline.py#L311-L317].
> It would be useful to support multiple main inputs and side inputs as well.
> Proposal:
> * Introduce a new method {{PTransformOverride.get_replacement_inputs(self,
> applied_ptransform)}} that can be overridden by end users. This method will
> be called to get the inputs for the replacement PTransform.
> * The default implementation will return a tuple of all the main inputs in
> order, concatenated with the all the side inputs {{PValue}} s in order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
