[
https://issues.apache.org/jira/browse/BEAM-8388?focusedWorklogId=476996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476996
]
ASF GitHub Bot logged work on BEAM-8388:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/20 04:50
Start Date: 01/Sep/20 04:50
Worklog Time Spent: 10m
Work Description: zeidoo commented on pull request #9779:
URL: https://github.com/apache/beam/pull/9779#issuecomment-684231771
Hi everyone,
I think I managed to move (**not upgrade**) all the Avro logic from sdk.core
to sdk.extensions.avro (right besides protobuf). I also updated all usages and
most tests seem to pass, as seen below. The tests that depended on Avro have
also been moved to sdk.extensions.avro. I had to also update some accessibility
modifiers from protected/private to public, that might be something undesirable
architecturally speaking. Really this is more of a first pass (ie: getting an
idea of what needs to be done).
`./gradlew -p sdks/java spotlessApply check --exclude-task
:sdks:java:extensions:ml:test --exclude-task
:sdks:java:io:google-cloud-platform:test --exclude-task :sdks:java:io:jdbc:test
--rerun-tasks`
`[... lots of output...]
BUILD SUCCESSFUL in 49m 45s
640 actionable tasks: 640 executed`
Here are the reasons I excluded some tasks:
- :sdks:java:extensions:ml:test --> no Google Computing Engine setup on my
machine
- :sdks:java:io:google-cloud-platform:test --> no Google cloud account set
up on my machine
- :sdks:java:io:jdbc:test --> one test failing two dates are one day apart,
no sure why, maybe due to my timezone?
Given I'm brand new to BEAM contributions and that Java isn't something I'm
very good at, I'd kindly request that someone who has good experience in both
to kindly spend some time with me doing a screen share so we can superficially
review my changes, make sure that the tests really do pass and help me do the
paperwork. (ie: PR, issue tracking, etc).
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 476996)
Remaining Estimate: 20h 10m (was: 20h 20m)
Time Spent: 3h 50m (was: 3h 40m)
> Update Avro to 1.9.1 from 1.8.2
> -------------------------------
>
> Key: BEAM-8388
> URL: https://issues.apache.org/jira/browse/BEAM-8388
> Project: Beam
> Issue Type: Improvement
> Components: io-java-avro
> Reporter: Jordanna Chord
> Priority: P3
> Original Estimate: 24h
> Time Spent: 3h 50m
> Remaining Estimate: 20h 10m
>
> Update build dependency to 1.9.1
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
